Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Define the working directory for add-in discovery #18999

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Dec 4, 2024

linked https://github.com/unoplatform/uno.hotdesign/issues/2986

Bugfix

Attempt to define the working directory

What is the current behavior?

Command fails for some user with:

[DEBUG][19:09:17.92]       Failed to get target frameworks of solution 'C:\Temp\Counter\Counter.sln'. This usually indicates that the solution is in an invalid state (e.g. a referenced project is missing on disk). Please fix and restart your IDE (command used: `dotnet build "C:\Temp\Counter\Counter.sln" --target:UnoDumpTargetFrameworks "-p:UnoDumpTargetFrameworksTargetFile=C:\Users\lcaze\AppData\Local\Temp\tmpint0b0.tmp" --verbosity quiet`). (cf. inner exception for more details.)
[DEBUG][19:09:17.92]       System.Exception: Unhandled exception. Microsoft.Build.Shared.InternalErrorException: MSB0001: Internal MSBuild Error: The switch name extracted from either the partially or completely unquoted arg should be the same.
[DEBUG][19:09:17.92]          at Microsoft.Build.Shared.ErrorUtilities.ThrowInternalError(String message, Exception innerException, Object[] args)
[DEBUG][19:09:17.92]          at Microsoft.Build.CommandLine.MSBuildApp.ExtractSwitchParameters(String commandLineArg, String unquotedCommandLineArg, Int32 doubleQuotesRemovedFromArg, String switchName, Int32 switchParameterIndicator)
[DEBUG][19:09:17.92]          at Microsoft.Build.CommandLine.MSBuildApp.GatherCommandLineSwitches(List`1 commandLineArgs, CommandLineSwitches commandLineSwitches)
[DEBUG][19:09:17.92]          at Microsoft.Build.CommandLine.MSBuildApp.GatherAllSwitches(String[] commandLine, CommandLineSwitches& switchesFromAutoResponseFile, CommandLineSwitches& switchesNotFromAutoResponseFile)
[DEBUG][19:09:17.92]          at Microsoft.Build.CommandLine.MSBuildApp.Execute(String[] commandLine)
[DEBUG][19:09:17.92]          at Microsoft.Build.CommandLine.MSBuildApp.Main(String[] args)

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

This is an attempt to workaround the issue for testing purposes. We might rollback this later.

@dr1rrb dr1rrb enabled auto-merge December 4, 2024 13:06
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.5

Copy link
Contributor

mergify bot commented Dec 4, 2024

backport release/stable/5.5

✅ Backports have been created

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18999/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18999/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149326 has failed on Uno.UI - CI.

@jeromelaban jeromelaban disabled auto-merge December 4, 2024 20:59
@jeromelaban jeromelaban merged commit 73bd119 into master Dec 4, 2024
108 of 114 checks passed
@jeromelaban jeromelaban deleted the dev/dr/useWD branch December 4, 2024 21:00
jeromelaban added a commit that referenced this pull request Dec 4, 2024
…5.5/pr-18999

fix: Define the working directory for add-in discovery (backport #18999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants