Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DateField): fix typo in DateField #1435

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore(DateField): fix typo in DateField #1435

merged 1 commit into from
Nov 20, 2024

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented Nov 18, 2024

Related to #1427.

Fixes typo in condition.

@epr3 epr3 self-assigned this Nov 18, 2024
@epr3 epr3 marked this pull request as ready for review November 18, 2024 15:56
@epr3 epr3 marked this pull request as draft November 18, 2024 15:56
@epr3
Copy link
Collaborator Author

epr3 commented Nov 18, 2024

@DamianGlowala I've created a CodeSandbox with the PR version of the package to reproduce the issue: https://codesandbox.io/p/devbox/n3h95q

But it seems that the segments and the ref value are in sync. Could you check out the sandbox and let me know what I'm missing?

Thank you!

@DamianGlowala
Copy link
Contributor

Hmm a bit odd, I'll swap my local pkg.pr.new version with radix-vue-1.9.9.tgz included in the above sandbox and report back ASAP (tomorrow morning/afternoon). Thank you for looking into this so far! 💯

@DamianGlowala
Copy link
Contributor

@epr3 would you agree that bumping radix-vue in the sandbox to 1.9.10 should clear segments when resetting the model value to undefined? Strangely, this doesn't seem to be the case.

@epr3
Copy link
Collaborator Author

epr3 commented Nov 19, 2024

@DamianGlowala true, but I've overlooked the line of code you pointed out on the last PR (#1427 (review)) and this one fixes it

@epr3 epr3 marked this pull request as ready for review November 19, 2024 18:09
@DamianGlowala
Copy link
Contributor

You're right, I've built radix-vue locally from this PR's branch and tried "radix-vue": "file:./radix-vue" to test this out. It works! 🥳

@zernonia zernonia merged commit 79e8509 into main Nov 20, 2024
3 checks passed
@sadeghbarati sadeghbarati deleted the fix-1426-date branch November 23, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants