Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freeze when stopping tracking from watch #14

Closed
wants to merge 1 commit into from

Conversation

skros89
Copy link

@skros89 skros89 commented Nov 1, 2018

This fixes #12 .
Previously when stopping tracking from watch the app would freeze because the exit timer is not started.

@Artaud
Copy link
Collaborator

Artaud commented Nov 1, 2018

Many thanks for your pull request! This wouldn't probably be the issue, let me explain:
there are two methods, forceExit() and normalExit()

forceExit() does what you'd expect: if the phone is connected, send a "STOPPING" message, and start an exit timer right away.

however normalExit() just sends the "STOPPING" message, and shouldn't start the exit timer (unless the phone is disconnected), because when the phone addon gets the STOPPING message, it will acknowledge receiving it by sending a "StopApp" message back. This will then start the exit timer.
So starting the exit timer right in the normalExit() method would break this ack.

@skros89
Copy link
Author

skros89 commented Nov 1, 2018

Oh yeah, I see. So this is more of a bad workaround, the issue is probably that the watch doesn't receive the "StopApp" message and stays stuck on stopping.

@skros89 skros89 closed this Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App on watch cannot be exited when in a specific state
2 participants