Docker Push in one Step (OrchardCMS#14850)

urbanit · Mar 18, 2024 · 34f13c5 · 34f13c5
1 parent c2f78e2
commit 34f13c5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/.github/workflows/preview_ci.yml b/.github/workflows/preview_ci.yml
@@ -58,11 +58,11 @@ jobs:
       uses: docker/setup-buildx-action@v3
     - name: Login to DockerHub
       if: matrix.os == 'ubuntu-latest'
-      uses: docker/login-action@v1
+      uses: docker/login-action@v3
       with:
         username: ${{ secrets.DOCKERHUB_USERNAME }}
         password: ${{ secrets.DOCKERHUB_PASSWORD }}
-    - name: Deploy preview docker image for linux
+    - name: Deploy preview docker image for linux and windows
       shell: pwsh
       if: matrix.os == 'ubuntu-latest'
       run: |
@@ -72,9 +72,5 @@ jobs:
         dotnet publish -c Release --property:PublishDir=$output --no-build --framework net8.0
         docker buildx build --load -f Dockerfile-CI --platform=linux/amd64 -t orchardproject/orchardcore-cms-linux:dev .
         docker push orchardproject/orchardcore-cms-linux:dev
-    - name: Deploy preview docker image for windows
-      shell: pwsh
-      if: matrix.os == 'ubuntu-latest'
-      run: |
         docker buildx build --load -f Dockerfile-CI --platform=windows/amd64 -t orchardproject/orchardcore-cms-windows:dev .
         docker push orchardproject/orchardcore-cms-windows:dev
diff --git a/.github/workflows/release_ci.yml b/.github/workflows/release_ci.yml
@@ -69,11 +69,11 @@ jobs:
       uses: docker/setup-buildx-action@v3
     - name: Login to DockerHub
       if: matrix.os == 'ubuntu-latest'
-      uses: docker/login-action@v1
+      uses: docker/login-action@v3
       with:
         username: ${{ secrets.DOCKERHUB_USERNAME }}
         password: ${{ secrets.DOCKERHUB_PASSWORD }}
-    - name: Deploy release docker image for linux
+    - name: Deploy release docker image for linux and windows
       shell: pwsh
       if: matrix.os == 'ubuntu-latest'
       run: |
@@ -84,10 +84,6 @@ jobs:
         docker buildx build --load -f Dockerfile-CI --platform=linux/amd64 -t orchardproject/orchardcore-cms-linux:latest -t orchardproject/orchardcore-cms-linux:${{ steps.get_version.outputs.VERSION }} .
         docker push orchardproject/orchardcore-cms-linux:latest 
         docker push "orchardproject/orchardcore-cms-linux:${{ steps.get_version.outputs.VERSION }}"
-    - name: Deploy release docker image for windows
-      shell: pwsh
-      if: matrix.os == 'ubuntu-latest'
-      run: |
         docker buildx build --load -f Dockerfile-CI --platform=windows/amd64 -t orchardproject/orchardcore-cms-windows:latest -t orchardproject/orchardcore-cms-windows:${{ steps.get_version.outputs.VERSION }} .
         docker push orchardproject/orchardcore-cms-windows:latest 
         docker push "orchardproject/orchardcore-cms-windows:${{ steps.get_version.outputs.VERSION }}"