Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature:(issue_1071) Add check for duplicated flags #1636

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

dearchap
Copy link
Contributor

@dearchap dearchap commented Jan 8, 2023

What type of PR is this?

(REQUIRED)

  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1071

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

make test

Release Notes

(REQUIRED)


@dearchap dearchap requested a review from a team as a code owner January 8, 2023 14:06
flag_impl.go Outdated Show resolved Hide resolved
Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🎉

@dearchap dearchap merged commit f60d3ef into urfave:main Jan 9, 2023
dearchap added a commit to dearchap/cli that referenced this pull request Jan 9, 2023
commit 4092431d53cec591309497b2ba680c07c947c695
Author: Naveen Gogineni <[email protected]>
Date:   Mon Jan 9 07:51:46 2023 -0500

    Fix tests

commit f60d3ef
Merge: 9be98f1 fa750ab
Author: dearchap <[email protected]>
Date:   Sun Jan 8 22:05:52 2023 -0500

    Merge pull request urfave#1636 from dearchap/issue_1071
dearchap added a commit to dearchap/cli that referenced this pull request Jan 9, 2023
commit 4092431d53cec591309497b2ba680c07c947c695
Author: Naveen Gogineni <[email protected]>
Date:   Mon Jan 9 07:51:46 2023 -0500

    Fix tests

commit f60d3ef
Merge: 9be98f1 fa750ab
Author: dearchap <[email protected]>
Date:   Sun Jan 8 22:05:52 2023 -0500

    Merge pull request urfave#1636 from dearchap/issue_1071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional check for duplicated string and int type flags.
3 participants