Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp get from cmd #1831

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Fix timestamp get from cmd #1831

merged 3 commits into from
Dec 4, 2023

Conversation

dearchap
Copy link
Contributor

@dearchap dearchap commented Dec 3, 2023

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

This makes the cmd.Timestamp(string) behaviour similar to other flags.

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

A new test case was added and run using

go test -run=TestCommand_Timestamp

(fill-in or delete this section)

Release Notes

(REQUIRED)


@dearchap dearchap requested a review from a team as a code owner December 3, 2023 22:58
Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

github-actions bot commented Dec 4, 2023

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@dearchap dearchap merged commit 6e7906d into urfave:main Dec 4, 2023
5 of 10 checks passed
@dearchap dearchap deleted the fix_ts branch December 4, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants