Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add generic flag back #2005

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Re-add generic flag back #2005

merged 4 commits into from
Nov 8, 2024

Conversation

dearchap
Copy link
Contributor

@dearchap dearchap commented Nov 6, 2024

What type of PR is this?

(REQUIRED)

  • feature

What this PR does / why we need it:

(REQUIRED)

Re add Generic flag as it is still useful in generated code by 3rd party tools.

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Added Generic tests from v2-maint.

Release Notes

(REQUIRED)

GenericFlag has been added back after initial removal from v3 as it seems to be useful for 3rd party plug-in code

@dearchap dearchap requested a review from a team as a code owner November 6, 2024 23:24
@dearchap dearchap merged commit ef45965 into urfave:main Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants