Disable tour animation #1728
Disable tour animation #1728
Conversation
| window.scrollBy( | ||
| 0, | ||
| rect.top - | ||
| window.scrollBy({ |
There was a problem hiding this comment.
Would be great if we add some Cypress tests
There was a problem hiding this comment.
Agreed. What would you test in this case? It still uses the same function window.scrollBy()
There was a problem hiding this comment.
Sorry for the delay @sammuell. We usually have a delay() between each step in the Cypress tests to make sure the transition is complete. Now that the transition can be enabled/disabled, we can probably have a test without that delay(), take a screenshot and that should capture the tooltip in its correct position. Would that be a useful test case?
| @@ -246,6 +246,7 @@ export default async function _showElement(targetElement) { | |||
| removeShowElement(); | |||
|
|
|||
| //we should wait until the CSS3 transition is competed (it's 0.3 sec) to prevent incorrect `height` and `width` calculation | |||
| let timeout = (self._options.tourAnimation) ? 350 : 1; | |||
There was a problem hiding this comment.
would be amazing if the timeout can also be configurable, maybe a new prop tooltipTimeoutMs to customize the timemout ms can be defined
This PR adds an option to disable any transitions of the tour (on by default). It also implements smooth page scrolling (issue #1719)