Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y improvements #1753

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

A11y improvements #1753

wants to merge 9 commits into from

Conversation

mrleblanc101
Copy link

Fix #1752

@mrleblanc101
Copy link
Author

I should probably have opened this as Draft while I work on fixing the test.

@mrleblanc101
Copy link
Author

I have 9 out of 24 test failing even on master on my machine saying the snapshot are too different.
Is the 0.05 threshold too low ?

@mrleblanc101
Copy link
Author

I have only 6 test failing, all with less than 0.07 variance on Github Action.
On my local machine, I'm not able to see that actual variance to fix it.
Do you think it would be possible to update the snapshot @afshinm ?

@mrleblanc101
Copy link
Author

@afshinm Just let me know if you see anything visual regression I could fix, otherwise this PR is ready.

@afshinm
Copy link
Contributor

afshinm commented Aug 19, 2022

Sounds good, thanks @mrleblanc101. Will have a look.

@lilsweetcaligula
Copy link

@afshinm @mrleblanc101 Hey guys. I just wanted to point out, - this PR also fixes a related bug, wherein the anchor/button element had its role="tab" overriden with role="button".

https://github.com/usablica/intro.js/blob/v6.0.0/src/core/showElement.js#L79
https://github.com/usablica/intro.js/blob/v6.0.0/src/core/showElement.js#L87
https://github.com/usablica/intro.js/blob/v6.0.0/src/util/setAnchorAsButton.js#L8

The bug is a problem because it poses a critical Web Accessibility error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve a11y by using button instead of links
3 participants