feat: add scrollElRef to support custom scroll element view #1877
+171
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clemdesign Sounds good. Could you rebase your branch please? |
…ch manage scroll (instead determine it by getScrollParent)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@afshinm done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose this PR in order to add options
scrollElRefwhich support a custom scroll element view.This one can be defined in global options set or in step options.
Where defined, the scroll action is defined on the element instead to be determinated by getParentScroll().
It useful typically in Ionic application where shadow container is defined and getParentScroll() not detect the scroll element. I tried to build a sample but not fully operational in Ionic-like context.