Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ci] adds working-directory default to the mypy job #559

Merged
merged 3 commits into from
Dec 9, 2024
Merged

[fix][ci] adds working-directory default to the mypy job #559

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a990e3
add defaults:run:working-directory
nowei Dec 7, 2024
e4f8673
align on setup-python versions + poetry install line
nowei Dec 7, 2024
a693c38
Merge branch 'main' into nowei/poetry-install-is-still-broken
as1729 Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/qa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ jobs:
mypy:
name: Type-check python
runs-on: ubuntu-latest
defaults:
run:
working-directory: python
steps:
- uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
with:
Expand All @@ -303,10 +306,12 @@ jobs:
persist-credentials: 'false'
- name: Install poetry
run: pipx install poetry
- uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version-file: 'python/pyproject.toml'
cache: poetry
- name: Install dependencies
run: poetry install --no-interaction --no-ansi
- name: Get Python changed files
id: changed-py-files
uses: tj-actions/changed-files@4edd678ac3f81e2dc578756871e4d00c19191daf # v45.0.4
Expand All @@ -318,9 +323,7 @@ jobs:
if: steps.changed-py-files.outputs.any_changed == 'true'
env:
CHANGED_PY_FILES: ${{ steps.changed-py-files.outputs.all_changed_files }}
run: |
poetry install --no-interaction --no-ansi
poetry run mypy $CHANGED_PY_FILES --ignore-missing-imports
run: poetry run mypy $CHANGED_PY_FILES --ignore-missing-imports

tflint:
name: Lint terraform
Expand Down
Loading