Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI builds fail when installing node-sass #219

Open
bertday opened this issue Jun 21, 2022 · 3 comments
Open

CI builds fail when installing node-sass #219

bertday opened this issue Jun 21, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@bertday
Copy link
Contributor

bertday commented Jun 21, 2022

The Netlify build for Bexar County's Storefront instance is failing with the error:

7:47:55 PM: error [email protected]: The engine "node" is incompatible with this module. Expected version ">=12". Got "10.24.1"
7:47:55 PM: error Found incompatible module.

For a sample failing build see: https://app.netlify.com/sites/bexar-food/deploys/62b1150a446d523ba2d29f5a

Cloning this locally to see if I can reproduce, and will likely upgrade node-sass.

@bertday bertday added the bug Something isn't working label Jun 21, 2022
@bertday bertday self-assigned this Jun 21, 2022
@bertday
Copy link
Contributor Author

bertday commented Jun 21, 2022

Checked out this repo out locally and ran through the setup notes in README.md. Got an error:

Failed to compile.

./src/index.scss
Node Sass version 6.0.1 is incompatible with ^4.0.0 || ^5.0.0.

Per this SO post, swapped out node-sass in favor of sass. The build script seems to be running now 🎉

Not sure that this is going to resolve the different node-sass error in Netlify CI that spawned this issue, but going to try deploying against the updated package.json and yarn.lock.

bertday added a commit that referenced this issue Jun 21, 2022
bertday added a commit that referenced this issue Jun 21, 2022
Tell Netlify to build this using the current Node LTS version (16). Related to #219.
@bertday
Copy link
Contributor Author

bertday commented Jun 21, 2022

Still getting the same Netlify error. It seems to be happening because Netlify is building using Node 10.x and both node-sass and sass expect at least 12.x. Per the Netlify docs, created a .nvmrc file pegging Node to 16.x (current active LTS).

bertday added a commit that referenced this issue Jun 21, 2022
This is part of the hotfix for #219. The site isn't deploying because of a bunch of linting errors. These seem to be mostly stylistic so disabling linting wholesale to get the Bexar County instance back online.
@bertday
Copy link
Contributor Author

bertday commented Jun 21, 2022

The Node version error seems to be resolved. Now getting a bunch of ESLint errors. See here for a sample failing build.

Disabling all linting for now; most of the errors seem to be minor/style-related. Not sure how this code base was passing previously 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant