Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps-dev): bump @babel/traverse from 7.22.4 to 7.23.2" #1592

Closed
wants to merge 1 commit into from

Conversation

astonm
Copy link
Collaborator

@astonm astonm commented Oct 19, 2023

This reverts commit 797ad52.

I'm hoping it repairs the currently-broken build.

@Mr0grog
Copy link
Collaborator

Mr0grog commented Oct 19, 2023

Ah, looks like the problem isn’t actually 797ad52 — it’s just that the Dockerfile is based on Node.js 18.16.0, and then tries to update NPM to the latest version, which requires >= 18.17.0. So this is just down to the passage of time. From the build log:

 > [base 2/9] RUN npm install -g npm:
 ERR! code EBADENGINE
0.998 npm ERR! engine Unsupported engine
0.998 npm ERR! engine Not compatible with your version of node/npm: [email protected]
0.999 npm ERR! notsup Not compatible with your version of node/npm: [email protected]
0.999 npm ERR! notsup Required: {"node":"^18.17.0 || >=20.5.0"}
0.999 npm ERR! notsup Actual:   {"npm":"9.5.1","node":"v18.16.0"}

The right fix is probably to update the Node.js version in the Dockerfile to the latest 18.x instead.

But also the site is shut down and just running static content, so this hasn’t caused any real problems, so no worries!

@Mr0grog
Copy link
Collaborator

Mr0grog commented Oct 19, 2023

Should be solved in #1593; I’m closing this.

@Mr0grog Mr0grog closed this Oct 19, 2023
@Mr0grog Mr0grog deleted the aston-broke-the-build branch October 20, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants