Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results Table Horizontal Responsiveness Updates #2065

Closed
ClaireValdivia opened this issue Oct 11, 2023 · 9 comments · Fixed by #2167
Closed

Results Table Horizontal Responsiveness Updates #2065

ClaireValdivia opened this issue Oct 11, 2023 · 9 comments · Fixed by #2167
Assignees
Labels
Grant Finder Issues related to the Grant Finder

Comments

@ClaireValdivia
Copy link
Contributor

ClaireValdivia commented Oct 11, 2023

Why is this issue important?

on smaller screens, grants table text overlaps and is difficult to read

Current State

Horizontal Fit - when the screen size is small, the text in the table overlaps

Image

Expected State

Fix horizontal resizing so that the text does not overflow in to the next cell.

Implementation Plan

tbd

Relevant Code Snippets

No response

@ClaireValdivia ClaireValdivia added the Grant Finder Issues related to the Grant Finder label Oct 11, 2023
@ClaireValdivia
Copy link
Contributor Author

@caitlinwinner is this ticket ready for an eng volunteer to look into and propose an approach?

@caitlinwinner
Copy link

@ClaireValdivia I think we should scope to two tickets. 1/fix horizontal resizing so that the text is clipped rather than overflowing in to the next cell. 2/ (less urgent) look into automatically fitting the vertical height to the screen height rather than using a fixed width.

@ClaireValdivia ClaireValdivia moved this from 📋 Scoping to 🔖 Ready in Grants Team Agile Planning Oct 19, 2023
@ClaireValdivia ClaireValdivia changed the title Results Table Responsiveness Updates Results Table Horizontal Responsiveness Updates Oct 20, 2023
@adele-usdr
Copy link
Contributor

Instead of clipping the text in the cells, should we have a minimum width of the table, and then allow the page to scroll horizontally, if the table is too big for the viewport?

@adele-usdr
Copy link
Contributor

Maybe a better question is - how is the design supposed to work in a narrow mobile layout?

@caitlinwinner
Copy link

the new https://grants.gov/search-grants does a pretty good job with this, take a look @adele-usdr

@adele-usdr
Copy link
Contributor

OK so in that example, the table does have a minimum width for the desktop layout, so at a certain point the table no longer fills the viewport and is truncated horizontally. On mobile though, for very narrow viewports, the table rows turn into vertically stacked items, so you can see all info on the screen. Seems like the ideal behavior to be truly responsive is to combine those approaches. When the window gets too narrow, instead of truncating the table row, shift into a vertically stacked presentation. Screenshot attached. There are layout issues with their controls on the left, but this is just to show the table row layout for the search results. @caitlinwinner does that approach make sense?
image

@caitlinwinner
Copy link

caitlinwinner commented Oct 30, 2023 via email

@adele-usdr adele-usdr self-assigned this Oct 30, 2023
@adele-usdr
Copy link
Contributor

Looks like the stacked layout properties don't work well combined with the sticky header. The sticky header seems more important, so I'll leave the stacked change for another time.

adele-usdr added a commit that referenced this issue Oct 30, 2023
Remove fixed attribute from grants-table
@adele-usdr adele-usdr linked a pull request Oct 30, 2023 that will close this issue
7 tasks
TylerHendrickson added a commit that referenced this issue Nov 2, 2023
Remove fixed attribute from grants-table

Co-authored-by: Tyler Hendrickson <[email protected]>
@github-project-automation github-project-automation bot moved this from 🔖 Ready to 🚢 Completed in Grants Team Agile Planning Nov 2, 2023
@ClaireValdivia ClaireValdivia moved this from 🚢 Completed to ✅ Staging in Grants Team Agile Planning Nov 9, 2023
@ClaireValdivia
Copy link
Contributor Author

seeing this in staging but not in prod so moving back to staging status for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Grant Finder Issues related to the Grant Finder
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants