Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2306 update size of logo to match profile badge size #2307

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

adele-usdr
Copy link
Contributor

Ticket #2306

Description

update size of logo to match profile badge size

Screenshots / Demo Video

screenshot_2023-12-05_at_8 35 59___am_720

Testing

Test that header size hasn't changed but height of logo matches profile logo.

Automated and Unit Tests

  • Added Unit tests

Manual tests for Reviewer

  • [x ] Added steps to test feature/functionality manually

Checklist

  • [x ] Provided ticket and description
  • [x ] Provided screenshots/demo
  • [x ] Provided testing information
  • Provided adequate test coverage for all new code
  • [x ] Added PR reviewers

@adele-usdr adele-usdr linked an issue Dec 5, 2023 that may be closed by this pull request
@adele-usdr adele-usdr enabled auto-merge (squash) December 5, 2023 17:43
Copy link

codeclimate bot commented Dec 5, 2023

Code Climate has analyzed commit fee51dd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 57.1% (0.0% change).

View more on Code Climate.

@adele-usdr adele-usdr merged commit 510814c into _staging Dec 5, 2023
5 checks passed
@adele-usdr adele-usdr deleted the adele-logo-sizing-update branch December 5, 2023 17:56
@TylerHendrickson TylerHendrickson added bug Something isn't working Grant Finder Issues related to the Grant Finder labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Grant Finder Issues related to the Grant Finder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update header logo size to match size of Profile icon
4 participants