-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vue-select component registration #3104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Something isn't working
javascript
Pull requests that update Javascript code
labels
May 28, 2024
QA Summary
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
as1729
approved these changes
May 28, 2024
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation Output
Plan Summary
Pusher: @jeffsmohan, Action: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #3103
Description
We noticed that the vue-select widgets were no longer rendering on staging, and the error was showing in console:
After investigation, it looks like switching to
type: "module"
inpackage.json
in #3089 changed howvue-select
got imported, so this PR fixes our usage to register the component properly in this context.Screenshots / Demo Video
Testing
Verified the console error is now gone and the widgets render and function correctly on my devbox.
Automated and Unit Tests
Manual tests for Reviewer
Checklist