Add assigned by user details to grants assigned to agencies endpoint #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
javascript
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
QA Summary
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation OutputPlan Summary
Pusher: @thucdtran, Action: |
…ls-in-assigned-agencies-endpoint
…ucdtran/assign-to-share-include-user-details-in-assigned-agencies-endpoint
jeffsmohan
approved these changes
Jun 18, 2024
| @@ -143,6 +156,10 @@ describe('`/api/grants` endpoint', () => { | |||
| const badResponse = await fetchApi(`/grants/${assignedEndpoint}`, agencies.offLimits, fetchOptions.admin); | |||
| expect(badResponse.statusText).to.equal('Forbidden'); | |||
| }); | |||
| it('includes assigned by information for the grant to an agency', async () => { | |||
| expect(json.find((a) => a.assigned_by_name === assignedBy.NV1.assigned_by_name)).to.be.ok; | |||
| expect(json.find((a) => a.assigned_by_name === assignedBy.NV2.assigned_by_name)).to.be.ok; | |||
There was a problem hiding this comment.
Seems worth testing the other fields are present too. Can we verify that name, email, and avatar color are all as expected?
There was a problem hiding this comment.
Done here as well!
| @@ -41,6 +41,19 @@ describe('`/api/grants` endpoint', () => { | |||
| }, | |||
| }; | |||
|
|
|||
| const assignedBy = { | |||
There was a problem hiding this comment.
Presumably this is pulled out here since it's used in both the tests you've added. I'd love to see it moved a bit closer to the code that uses it, like just within the closest common context block.
Another angle to consider (warning: personal opinion, feel free to disregard if you disagree!)... I actually find denormalizing this and just writing it out in each test is often easier to read and work with. If it's repeated a ton of times, then yeah, I'd pull it out, but if it's incidentally the same across two tests, I actually lean slightly toward just writing it out both times inline. There's a big benefit to keeping tests simple and easy to read.
…ucdtran/assign-to-share-include-user-details-in-assigned-agencies-endpoint
…ls-in-assigned-agencies-endpoint
thucdtran
deleted the
thucdtran/assign-to-share-include-user-details-in-assigned-agencies-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #3072
Description
Adds the following fields to
/api/organizations/[organization ID]/grants/[grant ID]/assign/agenciesendpoint.assigned_by_nameassigned_by_avatar_colorassigned_by_emailScreenshots / Demo Video
Testing
Added unit tests to check that we are returning new fields.
Manual testing can be done by checking to see what the agencies object in the assign-to-share feature is listed as for the grant detail page.
Checklist