-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding trace ids to email events #3410
Conversation
Not sure if |
QA Summary
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation Output
Plan Summary
Pusher: @mayabose, Action: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayabose I dropped a number of suggestions here, but they all really come down to the original suggestion that we only include trace IDs and span IDs when they are undefined – since the testing changes were pretty repetitive, I included them as comments.
Also, before it's totally ready, this PR will need to include a new trace_id_remapper
processor step in the datadog_logs_custom_pipeline
Terraform resource. Since the rest of that pipeline is defined in #3387, I suggest waiting until that PR is merged, and then updating this branch to amend the pipeline definition.
Conditionally include trace and span email tags, so undefined values are not included Co-authored-by: Tyler Hendrickson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayabose Looks good!
Ticket #3386
Description
Adding DataDog trace and span ids to email tags. Updated
email.test.js
to set default values for the tags.Automated and Unit Tests
Manual tests for Reviewer
Checklist