Feature: Adjust display for share grant events #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented `getOrganizationNotesForGrantByUser()` function in `grantsCollaboration/notes.js` - Renamed `getOrganizationNotesForGrant()` to `getCurrentNoteRevisions()` and updated signature - Made conditional `WHERE` clause for `grantId` and `userId` in `getCurrentNoteRevisions()` - Created API route `GET /:grantId/notes/user/:userId` in `grants.js` for fetching user-specific grant notes - Added validation for `afterRevision` and `limit` query parameters in the new API - Ensured results are paginated and ordered by `created_at` in descending order - Added necessary imports/exports in `grantsCollaboration/index.js`
…ific-user-FinderAPI
…t-notes-specific-user-FinderAPI' into feat/grant-notes
github-actions
bot
added
enhancement
QA Summary
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation OutputPlan Summary
Pusher: @greg-adams, Action: |
TylerHendrickson
requested changes
Oct 10, 2024
There was a problem hiding this comment.
@greg-adams Things are looking really nice in my local environment!
I only found one issue during testing (see my comments). Additionally, I'm wondering the packages/client/src/components/GrantNote.vue component is still being used anywhere. If not, can we delete that file (along with its tests) in this PR as well?
Comment on lines
+57
to
+61
| :user-name="userNote.user.name" | ||
| :user-email="userNote.user.email" | ||
| :team-name="userNote.user.team.name" | ||
| :avatar-color="userNote.user.avatarColor" | ||
| :created-at="userNote.createdAt" |
There was a problem hiding this comment.
This block appears to be missing something like :is-edited="userNote.isRevised" – when testing in my local environment, I'm missing the (edited) treatment in the {{ timeElapsedString }} (edited) part of the template.
There was a problem hiding this comment.
thanks for catching, I added this back in
Comment on lines
88
to
95
| class="activity-container" | ||
| :user-name="note.user.name" | ||
| :user-email="note.user.email" | ||
| :team-name="note.user.team.name" | ||
| :avatar-color="note.user.avatarColor" | ||
| :created-at="note.createdAt" | ||
| copy-email-enabled | ||
| :data-test-other-note-id="note.id" |
There was a problem hiding this comment.
Also missing an :is-edited prop (see previous comment)
|
Good catch, I also removed |
TylerHendrickson
approved these changes
Oct 11, 2024
|
@greg-adams Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #3240
Description
UserActivityItem)Screenshots / Demo Video
Testing
Automated and Unit Tests
Manual tests for Reviewer
Checklist