-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grants): login screen - update registration section text and links #3604
Conversation
QA Summary
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation Output
Plan Summary
Pusher: @lsr-explore, Action: |
name="email" | ||
placeholder="Email address" | ||
autofocus | ||
<main> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0947a18
to
af83888
Compare
…ort to shallowMount
af83888
to
383129d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for adding the test coverage and for looking out for a11y issues
if we upgrade vitest to a more recent version (in a future PR), we could use "getByRole" so that our tests are a bit more robust and use a11y role and name: https://main.vitest.dev/guide/browser/locators#getbyrole
Awesome @phm200 ! I was looking for something like that - I had used testing library for react on other projects. I'll play around with upgrading later next week. I plan to propose that we include https://www.npmjs.com/package/eslint-plugin-vuejs-accessibility as an eslint plugin. |
I also have a lot of experience with testing library and React. I haven't used the a11y plugin in eslint, but would be great to keep on top of a11y issues. Would be good to see how strict it is before turning on. From past work, when we enable new rules, we first fix all the rules in one or many PRs before turning on the rule in settings; just to reduce churn for others |
Ticket #3504
Description
Update the bottom registration section to match Figma
Approval from UX
Slack request post
Slack approval
Test Coverage
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
Before
LoginView.vue | 34.61 | 33.33 | 22.22 | 36 | 1,22,57,109-136
After
LoginView.vue | 59.25 | 38.88 | 44.44 | 61.53 | 23,136-158
Screenshots / Demo Video
App
Ticket
New Jersey
href="https://forms.office.com/pages/responsepage.aspx?id=0cN2UAI4n0uzauCkG9ZCp7ITdp07WUhBmfHGHVfxwctUNVFJNFNPUllWSTBQNFZCQlMyMjlWWU5NUiQlQCN0PWcu&route=shorturl"
Nevada
href="https://forms.office.com/pages/responsepage.aspx?id=5kCj5J64aE6OqhVE0nA5gBT1YIeXbrtMjy6yqM5ILm1UQVQwT0xOT1QxU0dNU1BDN05WWDdaVFRBRS4u&route=shorturl"
Testing
Automated and Unit Tests
Manual tests for Reviewer
Checklist