Set lto = "thin" for metadata build to fix linkme on macOS
#1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use-ink/ink#1827 uses
linkmeto collect events from external crates. However there is a known issue on macOS which can cause some events from external crates not to be added to theink_metadata::EVENTSdistributed slice.This PR attempts to fix this by setting
lto = "thin"for the release target when building the metadata.Notes:
ltoinprofile.releasewill override this default valueProfilepublic so that these can be set upon construction of theProfileProfileall optional, so that if not set then the default cargo profile settings will be used, see https://doc.rust-lang.org/cargo/reference/profiles.html#default-profiles