Add schema generation and verification #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkymanOne
changed the title
smiasojed
reviewed
Nov 17, 2023
smiasojed
reviewed
Nov 17, 2023
| @@ -142,6 +144,12 @@ enum Command { | |||
| /// workspace. | |||
| #[clap(name = "verify")] | |||
| Verify(VerifyCommand), | |||
| /// Generates schema from the current metadata specification. | |||
| #[clap(name = "generate-schema")] | |||
There was a problem hiding this comment.
I think it would be better to have a 'schema' command and use '-generate' and '-verify' as its arguments.
There was a problem hiding this comment.
Too many subcommands IMO: cargo contract schema ...
There was a problem hiding this comment.
I think info and call have more arguments, but it's up to you whether to leave them as they are or make changes.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1090 and use-ink/ink#1564
inkorpallet-contracts? - 5.0.0-alphaIntroudeces schema generation and verfication commands.
Description
This PR automated proces for metadata schema generation.
Whenever there are changes to the schema, if
cargo-contracttargets the latest version ofink_metadatathe scheme can be generated withcargo contract schema-generate inner/outer. This will print json to STDOUT.And here is the sample of how to verify the metadata against specified schema file:
Bundle:
Metadata file:
Checklist before requesting a review
CHANGELOG.md