Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker container on build failure #1531

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Remove docker container on build failure #1531

merged 2 commits into from
Mar 8, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Mar 7, 2024

Summary

Closes #_

  • y/n | Does it introduce breaking changes?
  • y/n | Is it dependent on the specific version of ink or pallet-contracts?
    Remove docker container on build failure

Description

It fixed an error where the docker container was left in an improper state after a build failure.
When a failure occurred during contract build, the container was left in an improper state. So, even when the user attempted to compile the contract with the fix, the build still failed due to the incorrect container state after the first build.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@smiasojed smiasojed merged commit d5cc2ef into master Mar 8, 2024
11 checks passed
@smiasojed smiasojed deleted the sm/rm-container branch March 8, 2024 10:23
This was referenced Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants