Verify raw Wasm in cargo contract verify
#1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
reviewed
Mar 20, 2024
Comment on lines
135
to
141
| let mut reader = BufReader::new(file); | ||
| let mut buffer: [u8; 32] = [0; 32]; | ||
| reader | ||
| .read_exact(&mut buffer) | ||
| .context(format!("Failed to read contract binary {}", path.display()))?; | ||
|
|
||
| let output_code_hash = CodeHash(buffer); |
There was a problem hiding this comment.
Why are you only reading the first 32 bytes of the Wasm binary here and then assume it's the hash?
ascjones
reviewed
Mar 20, 2024
There was a problem hiding this comment.
As commented, the whole files should be compared not just the first 32 bytes.
Also would be good to add to the existing integration test here.
In the issue it says:
We should add a argument --wasm that allows passing a binary obtained via e.g. cargo contract info --contract … --binary > contract.wasm.
If that is the common use case then it would be great to fetch that automatically, so you can just specify the account id in the verify command. @cmichi
ascjones
reviewed
Mar 21, 2024
Co-authored-by: Andrew Jones <[email protected]>
ascjones
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1539
inkorpallet-contracts?Adds a raw verification of the contract against the reference wasm binary.
The command executes the code in the
Releasemode by default and then compares the wasm output with the reference contract.Checklist before requesting a review
CHANGELOG.md