Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optimization-passes in the release profile #231

Merged
merged 11 commits into from
Mar 24, 2021
Merged

Support optimization-passes in the release profile #231

merged 11 commits into from
Mar 24, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Mar 23, 2021

Final piece for closing #169.

@cmichi cmichi requested a review from ascjones March 23, 2021 12:26
@cmichi cmichi removed the request for review from ascjones March 23, 2021 12:56
@cmichi cmichi marked this pull request as draft March 23, 2021 12:56
@cmichi cmichi marked this pull request as ready for review March 23, 2021 13:37
@cmichi cmichi requested a review from ascjones March 23, 2021 13:37
ascjones
ascjones reviewed Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is adding a custom key to a cargo profile the correct way to do it? Should we add our own e.g. cargo-contract custom section for this?

ascjones
ascjones reviewed Mar 23, 2021
View reviewed changes
src/workspace/manifest.rs Outdated Show resolved Hide resolved
ascjones
ascjones approved these changes Mar 24, 2021
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones merged commit 3454c12 into master Mar 24, 2021
@ascjones ascjones deleted the cmichi-use-optimization-flag-from-profile branch March 24, 2021 10:16
@cmichi cmichi mentioned this pull request Mar 31, 2021
Merged
@cmichi cmichi mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmichi @ascjones