-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for Windows #261
Add CI for Windows #261
Conversation
3dcc1e5
to
c1fef66
Compare
c1fef66
to
f31583f
Compare
f31583f
to
c6c454f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, CI stuff needs a double check from @TriplEight though.
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## [Unreleased] | |||
|
|||
### Fixed | |||
- Fixed `ERROR: The workspace root package should be a workspace member` when building a contract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
You'll drastically improve caching efficiency if you'll check some of your duplicated dependencies with different versions and lead them to a common denominator.
You mean the duplicates that show up if |
Yeah, kind of. Then there's nothing we can do :( |
Closes #36.
Took inspiration from here.
The Windows run currently takes ~9 minutes.
While implementing this, I found the bug which caused some people asking in our channels why they got this error when building a contract under Windows:
It was due to a comparison of a non-canonicalized path with a canonicalized one.
The
\\\\?
prefix appears only under Windows ‒ there a path with this prefix is the correct canonical path, this allows Windows-specific "long" paths (more info).I'm not sure if there might be more places in our code which could cause issues with this path discrepancy, FWIW tests are green.
I can do a new release once we have merged this.