Fix linting support on Apple Silicon #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
requested review from
Robbepop,
cmichi,
ascjones and
HCastano
as code owners
cmichi
reviewed
Apr 4, 2022
|
@athei I've created this debugging PR based on yours. For Windows there are two files in the folder: |
|
@athei The CI runs through on my debugging PR, so I think if you copy the |
cmichi
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478
Apple Silicon wasn't defined in the
config.tomlof our linting project. And hencedylint-linkwasn't used to produce the binary. I also added a hand full of other common architectures.This won't fix the windows CI, though. I am not sure what is up with that.