Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

fix(kiam-server-manifests): change localhost ref #163

Merged
merged 2 commits into from
Oct 10, 2018
Merged

fix(kiam-server-manifests): change localhost ref #163

merged 2 commits into from
Oct 10, 2018

Conversation

tasdikrahman
Copy link
Contributor

closes #162

@pingles pingles merged commit 1458471 into uswitch:master Oct 10, 2018
@pingles
Copy link
Contributor

pingles commented Oct 10, 2018

Thanks @tasdikrahman and @roffe for the original reference.

@tasdikrahman tasdikrahman deleted the fix/health-checks branch October 11, 2018 03:03
@ewbankkit ewbankkit mentioned this pull request Oct 17, 2018
Merged
3 tasks
hakamadare added a commit to hakamadare/charts that referenced this pull request Jan 1, 2019
@hakamadare
Track upstream v3-release tag, use loopback IP for probes
4af421e 
This addresses two issues that I encountered when using this chart to
deploy kiam v3 on EKS:
1. kiam v3.0 was released 2018-12-06 per
https://github.com/uswitch/kiam/blob/master/CHANGELOG.md, it probably
doesn't make sense to track a RC tag
2. Liveness/readiness probes need to use `127.0.0.1` rather than
`localhost` (see uswitch/kiam#163) because of a TLS change
hakamadare added a commit to hakamadare/charts that referenced this pull request Jan 1, 2019
@hakamadare
Track upstream v3-release tag, use loopback IP for probes
b711b27 
This addresses two issues that I encountered when using this chart to
deploy kiam v3 on EKS:
1. kiam v3.0 was released 2018-12-06 per
https://github.com/uswitch/kiam/blob/master/CHANGELOG.md, it probably
doesn't make sense to track a RC tag
2. Liveness/readiness probes need to use `127.0.0.1` rather than
`localhost` (see uswitch/kiam#163) because of a TLS change

Signed-off-by: Steve Huff <[email protected]>
@hakamadare hakamadare mentioned this pull request Jan 1, 2019
Merged
2 tasks
hakamadare added a commit to hakamadare/charts that referenced this pull request Jan 1, 2019
@hakamadare
Track upstream v3-release tag, use loopback IP for probes
1c79b5b 
This addresses two issues that I encountered when using this chart to
deploy kiam v3 on EKS:
1. kiam v3.0 was released 2018-12-06 per
https://github.com/uswitch/kiam/blob/master/CHANGELOG.md, it probably
doesn't make sense to track a RC tag
2. Liveness/readiness probes need to use `127.0.0.1` rather than
`localhost` (see uswitch/kiam#163) because of a TLS change

Signed-off-by: Steve Huff <[email protected]>
hakamadare added a commit to hakamadare/charts that referenced this pull request Jan 3, 2019
@hakamadare
Track upstream v3-release tag, use loopback IP for probes
eb166d0 
This addresses two issues that I encountered when using this chart to
deploy kiam v3 on EKS:
1. kiam v3.0 was released 2018-12-06 per
https://github.com/uswitch/kiam/blob/master/CHANGELOG.md, it probably
doesn't make sense to track a RC tag
2. Liveness/readiness probes need to use `127.0.0.1` rather than
`localhost` (see uswitch/kiam#163) because of a TLS change

Signed-off-by: Steve Huff <[email protected]>
hakamadare added a commit to hakamadare/charts that referenced this pull request Jan 4, 2019
@hakamadare
Track upstream v3-release tag, use loopback IP for probes
f2fbb7f 
This addresses two issues that I encountered when using this chart to
deploy kiam v3 on EKS:
1. kiam v3.0 was released 2018-12-06 per
https://github.com/uswitch/kiam/blob/master/CHANGELOG.md, it probably
doesn't make sense to track a RC tag
2. Liveness/readiness probes need to use `127.0.0.1` rather than
`localhost` (see uswitch/kiam#163) because of a TLS change

Signed-off-by: Steve Huff <[email protected]>
@cheeseandcereal cheeseandcereal mentioned this pull request Jan 15, 2019
Open
cpanato pushed a commit to hakamadare/charts that referenced this pull request Jan 28, 2019
@hakamadare @cpanato
Track upstream v3-release tag, use loopback IP for probes
731ca10 
This addresses two issues that I encountered when using this chart to
deploy kiam v3 on EKS:
1. kiam v3.0 was released 2018-12-06 per
https://github.com/uswitch/kiam/blob/master/CHANGELOG.md, it probably
doesn't make sense to track a RC tag
2. Liveness/readiness probes need to use `127.0.0.1` rather than
`localhost` (see uswitch/kiam#163) because of a TLS change

Signed-off-by: Steve Huff <[email protected]>
hakamadare added a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
@hakamadare
Track upstream v3-release tag, use loopback IP for probes
de10d18 
This addresses two issues that I encountered when using this chart to
deploy kiam v3 on EKS:
1. kiam v3.0 was released 2018-12-06 per
https://github.com/uswitch/kiam/blob/master/CHANGELOG.md, it probably
doesn't make sense to track a RC tag
2. Liveness/readiness probes need to use `127.0.0.1` rather than
`localhost` (see uswitch/kiam#163) because of a TLS change

Signed-off-by: Steve Huff <[email protected]>
hakamadare added a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
@hakamadare
Track upstream v3-release tag, use loopback IP for probes
1bbb2e6 
This addresses two issues that I encountered when using this chart to
deploy kiam v3 on EKS:
1. kiam v3.0 was released 2018-12-06 per
https://github.com/uswitch/kiam/blob/master/CHANGELOG.md, it probably
doesn't make sense to track a RC tag
2. Liveness/readiness probes need to use `127.0.0.1` rather than
`localhost` (see uswitch/kiam#163) because of a TLS change

Signed-off-by: Steve Huff <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pingles pingles pingles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change localhost references to 127.0.0.1
2 participants
@tasdikrahman @pingles