This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Metadata server: Use 301 rather than 308 redirects #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 20b1c39, requests for the security-credentials URL were changed to redirect to security-credentials/ with a trailing slash. However, this uses http.StatusPermanentRedirect, which corresponds to a 308, whereas the real metadata API issues a 301 redirect (http.StatusMovedPermanently). Some clients do not handle the 308 correctly and fail to retrieve credentials. We've noticed broken behaviour in the Go sdk version 1.4.10, which is used by docker-machine.
pingles
approved these changes
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172. Tested and confirmed that this allows the Go SDK version 1.4.10 to retrieve credentials from kiam.