-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA CICD #1449
Add GHA CICD #1449
Conversation
.# [why] `mem::ununitialized()` is deprecated as of rust v1.39.0. And this use is likely a premature optimization attempting to avoid initializing the byte array to 0, which is usually a *very* fast operation. * ref: <https://github.com/rust-lang/rust/blob/master/RELEASES.md> * ref: <https://stackoverflow.com/questions/3654905/faster-way-to-zero-memory-than-with-memset>
…t ... = if ...`)
…e` => `for ... in`)
…s) of 'Cargo.toml'
…e if clause)' .# [why] The initial refactoring/repair led to comments within if conditions which is objectionable to some of the devs. So, this changes the refactor to completely split the if clauses into separate if statements (with corresponding commentary). Note: this refactor is "less mechanical" and does increase the risk of changing the actual effect of the code. But the change is small and the tests are passing.
…stream - fixes musl (no-utmpx) build bug - fixes failing windows real{link,path} tests
@rivy still planning to land it today? |
Yes, any objections? ... or any change requests? |
nope, au contraire :) |
Alright, I'm doing a test merge right now on my repository; it should complete testing in about 15 minutes. If the test completes without errors, I merge it. I think the But at least PRs based on the new |
Merged to I've just push a |
Woohoo! Thanks for you hard work @rivy |
bravo, you can be proud :) |
cargo fmt
done to allow for style testing in CICDcargo build
compiles successfully on all platforms (compiling the set of uutils which are fully cross-platform)cargo make
enhanced...cargo make
... builds the full host platform util set intouutils
cargo make utils [UTIL]...
... builds individual utilscargo make features FEAT [FEAT]...
... buildsuutils
using specified featurescargo make help
shows all additional available sub-commands... PR is on top of fix.lints (PR #1443 )
(14 commits => rivy/rs.coreutils@fix.lints...rivy:add.cicd)
Note: you'll likely have to enable GitHub actions to get the CICD running.
Fixes: #1419
Fixes: #1366
Fixes: #1364
Fixes: #1361
Fixes: #1187
Fixes: #1122
Fixes: #1102
Fixes: #1433 (?; at least a start of a usable cargo make)
Fixes: #1174 (addresses default build issue)