df: fix rounding issue in test #5532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
force-pushed
the
df_fix_5531
branch
from
5645371
to
6861df1
Compare
|
GNU testsuite comparison: |
Set block size to 1 so the returned values are the same values as used for the calculation of the percentage values
sylvestre
force-pushed
the
df_fix_5531
branch
from
6861df1
to
0164934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a rounding issue in
test_use_percentage. Because the test used the default block size of1024, the returned values for the columnsUsedandAvailwere rounded. However, the test used them to calculate the percentage values to compare them with the values returned in theUse%column. In some cases, the rounding led to a mismatch between those values and that caused the test to fail. By setting the block size to1, the returned values forUsedandAvailare no longer rounded.Fixes #5531