Fire signal when user attempts to login with invalid password #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbugni
approved these changes
Aug 14, 2018
docs/source/includes/signals.txt
Outdated
| @@ -7,5 +7,6 @@ | |||
| user_forgot_password # a user submitted a reset password request | |||
| user_logged_in # a user logged in | |||
| user_logged_out # a user logged out | |||
| user_password_invalid # a user attempted to login with invalid password | |||
There was a problem hiding this comment.
hmm, don't love "invalid", as it's a failed verification or lookup, not that the password itself is invalid.
user_password_attempt_failed ?
CodeRhymesLife
commented
Aug 14, 2018
| @@ -36,6 +36,9 @@ | |||
| # Sent when a user logged out | |||
| user_logged_out = _signals.signal('user.user_logged_out') | |||
|
|
|||
| # Sent when a user attempted to login and password verification failed | |||
| user_password_failed = _signals.signal('user.password_failed') | |||
There was a problem hiding this comment.
Looking a little closer, his other variables follow this pattern:
user_<action>
Our doesn't. To follow this pattern we should go with something like:
user_failed_password_verification
This is unfortunately a long name. I'm going to stick with user_password_failed, submit a PR and leave a comment to see what he thinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following issue in Flask-User where there is no way to be notified when a user attempts to login with an invalid password.
These changes:
Once this is in I'll submit a PR against Flask-User.