-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mosaic server in Python #287
Conversation
domoritz
commented
Feb 2, 2024
•
edited
Loading
edited
- working websocket
- create and load budles
- basic unit tests
- http
- cache to disk
This is looking great. Thank you!! Would it help to name the package folder “python-server” or “python-duckdb-server” to better indicate what the package provides? |
Totally unscientific but the Python server seems to perform pretty well. Here are the logs of me brushing back and forth a bit. I tried a version of the python server with https://websockets.readthedocs.io/ and it wasn't as fast as the one with socketify but again I didn't do any clean experiments. Node server Python server |
I prefer not to have the programming language in the package name. But we could name it I was also thinking we would replace the existing server completely. Is there a strong reason to keep the node sever? |
I'd rather error on the side of being helpfully specific, so maybe
I definitely want to keep the DuckDB node client class in the |
@jheer The server should be feature complete now. There are a bunch of more things we can do but I think this is a good starting point for more experiments. |