Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset selection source upon clause eviction #37

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Reset selection source upon clause eviction #37

merged 2 commits into from
Mar 3, 2023

Conversation

jheer
Copy link
Member

@jheer jheer commented Mar 3, 2023

Selections with a single resolution strategy will evict an existing clause upon updates. This PR adds a mechanism for reporting this eviction back to a clause source: if a source has a reset() method, it will be invoked upon clause eviction.

Both the menu and search widgets and the Interval1D and Interval2D interactors now have reset() methods that clear their interactive state upon selection clause eviction.

@jheer jheer requested a review from domoritz March 3, 2023 18:35
@jheer
Copy link
Member Author

jheer commented Mar 3, 2023

@domoritz This provides the "single brush" functionality discussed under #35.

@jheer jheer merged commit afd7e58 into main Mar 3, 2023
@jheer jheer deleted the jh/brush-clear branch March 3, 2023 18:42
@manzt
Copy link
Collaborator

manzt commented Jul 22, 2024

Is there a mechanism to batch .reset() calls? For instance, I'd like to wire up a button to efficiently "Reset all" 1DIntervals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants