Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sub-RFC for increased availability of NUMA API #1545

Open
wants to merge 8 commits into
base: dev/vossmjp/rfc_numa_support
Choose a base branch
from
Open

Add sub-RFC for increased availability of NUMA API #1545

wants to merge 8 commits into from

Conversation

aleksei-fedotov
Copy link
Contributor

Description

Add sub-RFC to #1535 for increased availability of NUMA API.

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

vossmjp
vossmjp reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@vossmjp vossmjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small wording issues.

rfcs/proposed/simplified_numa_support/increased_availability/README.org Outdated Show resolved Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org Outdated Show resolved Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org Outdated Show resolved Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org Outdated Show resolved Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org Outdated Show resolved Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org Outdated Show resolved Hide resolved
rfcs/proposed/simplified_numa_support/increased_availability/README.org Outdated Show resolved Hide resolved
@aleksei-fedotov aleksei-fedotov force-pushed the dev/aleksei-fedotov/rfc_numa_support-increased-availability branch from 83b8788 to 5e8b79e Compare November 14, 2024 09:27
akukanov
akukanov reviewed Nov 14, 2024
View reviewed changes
rfcs/proposed/numa_support/increase-numa-support-availability.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org Outdated
[2] [[https://github.com/open-mpi/hwloc][HWLOC project repository on GitHub]]

* Proposal
1. Introduce new variant of the ~tbbbind~ library with the name ~tbbbind_static~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly an open question: Could it make sense to drop support of HWLOC 1.x and use the name tbbbind (with no suffixes) for this new statically linked variant? That would also avoid the need to ship one more binary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an interesting point. I am not aware about anyone who uses HWLOC 1.x. Perhaps, there is even lack of official support for the OSes where HWLOC 1.x can be used.
On the other hand, it seems to be an unrelated thing and could be proposed separately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rather disagree about it being unrelated, as it directly addresses one of the shortcomings of the proposal.

rfcs/proposed/numa_support/increase-numa-support-availability.org Outdated Show resolved Hide resolved
akukanov
akukanov reviewed Nov 14, 2024
View reviewed changes
rfcs/proposed/numa_support/increase-numa-support-availability.org Outdated Show resolved Hide resolved
rfcs/proposed/numa_support/increase-numa-support-availability.org Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, a name better reflecting the gist of the proposal would make more sense. For example, "tbbbind-link-static-hwloc"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the title need to get updated as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akukanov akukanov akukanov left review comments

@vossmjp vossmjp vossmjp left review comments

@pavelkumbrasev pavelkumbrasev Awaiting requested review from pavelkumbrasev

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleksei-fedotov @vossmjp @akukanov