Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation 'auto' doesn't calculate to correctly #2588 #2589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huseyinturkmenoglu
Copy link

Q A
Bug fix? yes
New feature? yes
Related tickets fixes #2588
License MIT

I developed a solution for #2588.

I changed line 738 and added a new attribute name is 'fixedHeight'. It defaults value 0, but the user/developer wants to add fixed height for top or bottom, they can use this attribute. Due to this attribute of datepicker orientation, the same way as the first created. This doesn't change the starting position for months, years, decades, centuries.

Maximum height value of 250. If the height change and decreases from 250, it return always 250. This is helpful for starting datepicker position and doesn't allow change according to the lowest height. If the height value higher than 250, it returns the highest value.

top_overflow = -scrollTop + top - (calendarHeight < 250 ? 250 : calendarHeight) - fixedHeight;

I share screens about my change.

First, fixedHeight equals 0. It's default value 0. This is like 'orientation' defaults values 'auto'. Calculation correct, but the user/developer doesn't change fixedHeight according to their header heights. For instance, this header height is 50px.
image

Second, I give 50, because of this example header height 50px.

image

image

I hope, my issue and solution help us.

If you don't like this solution. Please can you give a trick or develop any solution for #2588.

Thanks,
Greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orientation 'auto' doesn't calculate to correctly
1 participant