Orientation 'auto' doesn't calculate to correctly #2588 #2589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I developed a solution for #2588.
I changed line 738 and added a new attribute name is 'fixedHeight'. It defaults value 0, but the user/developer wants to add fixed height for top or bottom, they can use this attribute. Due to this attribute of datepicker orientation, the same way as the first created. This doesn't change the starting position for months, years, decades, centuries.
Maximum height value of 250. If the height change and decreases from 250, it return always 250. This is helpful for starting datepicker position and doesn't allow change according to the lowest height. If the height value higher than 250, it returns the highest value.
top_overflow = -scrollTop + top - (calendarHeight < 250 ? 250 : calendarHeight) - fixedHeight;
I share screens about my change.
First, fixedHeight equals 0. It's default value 0. This is like 'orientation' defaults values 'auto'. Calculation correct, but the user/developer doesn't change fixedHeight according to their header heights. For instance, this header height is 50px.
Second, I give 50, because of this example header height 50px.
I hope, my issue and solution help us.
If you don't like this solution. Please can you give a trick or develop any solution for #2588.
Thanks,
Greetings