strip bootstrap repos and remove EOL OSes #8793

mcalmer · 2024-05-22T15:03:37Z

What does this PR change?

strip bootstrap repos to contain only venv-salt-minion and dependencies
remove OS definitions which do not have the salt bundle

GUI diff

No difference.

DONE

Documentation

TBD
DONE

Test coverage

No tests: already covered
DONE

Links

Issue: https://github.com/SUSE/spacewalk/issues/19896

DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

Re-run test "changelog_test"
Re-run test "backend_unittests_pgsql"
Re-run test "java_pgsql_tests"
Re-run test "schema_migration_test_pgsql"
Re-run test "susemanager_unittests"
Re-run test "javascript_lint"
Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

srbarrios · 2024-05-24T08:16:18Z

It looks something to be well tested before merging.
If you have the opportunity to run this in a uyuni-pr test pipeline, that would be great, it will not cover all the products like in BV... but at least we will cover one.

admd · 2024-07-23T09:46:56Z

@deneb-alpha @m-czernek can you please take a look here tomorrow.

m-czernek

From my POV, this is OK, though I'm unable to verify all package changes, e.g. not sure why we're keeping gnupg on Debian but not on Ubuntu. I can see that we require it in https://build.opensuse.org/projects/systemsmanagement:saltstack:bundle:next/packages/venv-salt-minion/files/venv-salt-minion.spec?expand=1; I assume that's because of old versions on the debian systems?

susemanager/susemanager.changes.mc.shrink-bootstrap-repos

mcalmer · 2024-10-23T07:12:52Z

From my POV, this is OK, though I'm unable to verify all package changes, e.g. not sure why we're keeping gnupg on Debian but not on Ubuntu. I can see that we require it in https://build.opensuse.org/projects/systemsmanagement:saltstack:bundle:next/packages/venv-salt-minion/files/venv-salt-minion.spec?expand=1; I assume that's because of old versions on the debian systems?

Debian does not have it installed by default. Don't ask me why.

mcalmer · 2024-10-23T07:40:57Z

It looks something to be well tested before merging. If you have the opportunity to run this in a uyuni-pr test pipeline, that would be great, it will not cover all the products like in BV... but at least we will cover one.

That pipeline is currently not due to containers

m-czernek

Ok, understood. +1 from my side.

deneb-alpha

Leaving a summary here because on some parts of the file I wasn't able to properly drop a suggestion.

Debian 9 to 10 are EOL already, Debian 11 is currently in our grace period too
Ubuntu 18.04 is EOL too. We only submit from 20.04 on
For SLE, 15 SP0 and SP1 should be already EOL
On the SLE 12 side, I admit I don't know if there are special contracts going on, but to my knowledge, everything older than 12-SP5 excluded could be finally dropped
for SLES4SAP 11 SP4, I think there's still some support going on
not sure if we want to drop older SUMA versions too. I think in the list I saw some 4.0 entries too
Leap 15.4 is EOL too and 15.5 will be EOL end of 2024.
on some package lists I suggested to harmonize how we write the list of packages. From what I saw on past reviews, the way I suggested usually creates a better diff when we drop or add more packages, but of course, feel free to ignore the suggestion if you think it's not a good idea.