-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for FUSS #9502
base: master
Are you sure you want to change the base?
Add support for FUSS #9502
Conversation
base_channels = fuss-12-pool-amd64-uyuni | ||
repo_url = http://deb.debian.org/debian/dists/bookworm-backports/main/binary-amd64/ | ||
|
||
[fuss-12-custom-main-amd64-uyuni] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they call it custom on their side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know how to call it, otherwise the name was the same than the base channel. Open to suggestions...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the name of the file that has it? Or what does the doc says when talking about this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the name of the file that has it? Or what does the doc says when talking about this repo?
root@fuss-12:~# cat /etc/apt/sources.list
deb http://deb.debian.org/debian/ bookworm main non-free-firmware contrib non-free
deb-src http://deb.debian.org/debian/ bookworm main non-free-firmware contrib non-free
deb http://security.debian.org/debian-security bookworm-security main non-free-firmware contrib non-free
deb-src http://security.debian.org/debian-security bookworm-security main non-free-firmware contrib non-free
root@fuss-12:~# cat /etc/apt/sources.list.d/
archive_fuss_bz_it.list google-chrome.list
root@fuss-12:~# cat /etc/apt/sources.list.d/archive_fuss_bz_it.list /etc/apt/sources.list.d/google-chrome.list
deb [signed-by=/usr/share/keyrings/fuss-keyring.gpg] http://archive.fuss.bz.it/ bookworm main contrib non-free
### THIS FILE IS AUTOMATICALLY CONFIGURED ###
# You may comment out this entry, but any other modifications may be lost.
deb [arch=amd64] https://dl.google.com/linux/chrome/deb/ stable main
Do you want to change fuss-12-custom-main-amd64-uyuni
to fuss-12-fuss-main-amd64-uyuni
?
Second question, as it seems to have Google Chrome repository enabled by default, should I add it as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm wondering whether the repos are completely accurate or not (even if everything's working), probably being very picky, but according to that, I should have:
- 4 repos for the first line (main, non-free-firmware, contrib, non-free)
- 4 repos for the 3rd line (same ones, but in debian-security)
- 3 repos for the FUSS specific ones, in the sources.list.d directory (main, contrib, non-free)
- The 2 usual ones for Uyuni tools (stable + development).
- Google Chrome repository, if we decide to add it.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm, I only see you added 9 repos, two of them being client tools... but in this list you have 14?
So looks to me you're indeed missing repositories, even from Debian maybe?
I'd add all.
My suggestion would be:
- Those coming from Debian, to start with
fuss-12-debian-
. They are not really custom, right? Just Debian12 repos :-) - Those coming from FUSS, to start with
fuss-12-fuss-
. They are really coming from FUSS - Those for the Uyuni tools, keep it as is
- The one for Chrome:
fuss-12-googlechrome-amd64-uyuni
. It comes from googlechrome.
Keep in mind changing the prefix for Debian means you will need to refresh the the bootstrap repo definition as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few additional notes from my side
Add extra packages to bootstrap repository, correct FUSS name in changelogs
What does this PR change?
Add support for a new distribution into Uyuni, FUSS (which should be valid for both FUSS Server or FUSS Client).
GUI diff
A new distribution will exist.
Documentation
Documentation issue needs to be created: Link for SUSE Manager contributors, Link for community contributors.
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests: It's a 100% clone of Debian 12, no tests needed.
DONE
Links
Issue(s): #
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!