Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAR-5614][External] Make the NifTI importer re-orient files to orientation of target file instead of LPI #996

Closed
wants to merge 4 commits into from

Conversation

JBWilkie
Copy link
Collaborator

@JBWilkie JBWilkie commented Jan 30, 2025

Problem

Since we released the DISABLE_REORIENTATION_ON_UPLOAD feature flag, not every post-MED_2D_VIEWER file will be in the LPI orientation, but the current NifTI importer assumes they are

This ticket is to introduce logic into the NifTI importer similar to the export logic so that we re-orient inbound annotations to the target file instead of statically to LPI

Solution

Re-orient inbound NifTI annotations to the orientation of the remote file it's targeting

Changelog

Support for importing NifTI annotations to non-LPI oriented dataset files

@JBWilkie JBWilkie changed the title [DAR-5614][External] [DAR-5614][External] Make the NifTI importer re-orient files to orientation of target file instead of LPI Jan 30, 2025
@JBWilkie
Copy link
Collaborator Author

JBWilkie commented Feb 6, 2025

Plans have changed - We are going to remove the DISABLE_REORIENTATION_ON_UPLOAD feature flag, so this change is not necessary

@JBWilkie JBWilkie closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant