Skip to content

Commit

Permalink
v8: Prepare for swallowed rejection hook.
Browse files Browse the repository at this point in the history
This is done in preparation for landing

  https://chromium-review.googlesource.com/c/v8/v8/+/1126099

on the V8 side, which extends the existing PromiseRejectEvent mechanism
with new hooks for reject/resolve after a Promise was previously
resolved already.

Refs: nodejs/promises-debugging#8
Design: https://goo.gl/2stLUY
  • Loading branch information
bmeurer authored and hashseed committed Jul 11, 2018
1 parent 625d843 commit d11dafa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/bootstrapper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void PromiseRejectCallback(PromiseRejectMessage message) {
callback = env->promise_reject_handled_function();
value = Undefined(isolate);
} else {
UNREACHABLE();
return;
}

Local<Value> args[] = { promise, value };
Expand Down

0 comments on commit d11dafa

Please sign in to comment.