Remove sleepAsync from tests/testswitch #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menduist
commented
Oct 27, 2022
|
|
||
| var peerId = PeerId.init(PrivateKey.random(ECDSA, rng[]).get()).get() | ||
| let connectFut = switch.connect(peerId, transport.addrs) | ||
| await sleepAsync(500.millis) |
There was a problem hiding this comment.
This test was not actually testing cancellation since the connect was finished far before 500 milliseconds
This will be tested properly in #611
lchenut
previously approved these changes
Oct 27, 2022
lchenut
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's flaky
We should aim to remove as many sleepAsync as possible, as they are generally synonyms with flaky tests. Exception being tests actually based on time