Fix use_eip implementation and documentation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure that var.use_eip is true when creating DNS record
Draft
Also add the EIP id to module outputs in case `use_route53` is `false` and user needs access to elastic IP details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
use_eipvariable wasn't actually used to determine if an Elastic IP should be created or not. The Elastic IP resource now checks forvar.use_eip.Since
use_route53and the DNS record assumes the Elastic IP is available, also make sure bothvar.use_route53andvar.use_eiparetruewhen creating the DNS record.Finally, this also make the Elastic EIP id a module output for the scenario where an EIP is wanted but no DNS but still need access to the EIP created by the module.
NOTE: This assumes PR #6 is merged first.
fixes #5