fix: some fixes to isIdentityCard('he-IL') (#1048)

* added support for IL in isIdentityCard()

* fix ci

* fix CI #2

* fix CI #3

* fix conflicts

* chnage locale to 'he-IL'

* change regex and if statments

remove inefficient code.

* remove if statement ,its not needed.

* fix eslit problem

lib/isIdentityCard.js

@@ -33,7 +33,7 @@ var validators = {
     return sanitized.endsWith(controlDigits[number % 23]);
   },
   'he-IL': function heIL(str) {
-    var DNI = /^\d+$/; // sanitize user input
+    var DNI = /^\d{9}$/; // sanitize user input
 
     var sanitized = str.trim(); // validate the data structure
 
@@ -42,12 +42,6 @@ var validators = {
     }
 
     var id = sanitized;
-
-    if (id.length !== 9 || isNaN(id)) {
-      // Make sure ID is formatted properly
-      return false;
-    }
-
     var sum = 0,
         incNum;
 

src/lib/isIdentityCard.js

@@ -31,7 +31,7 @@ const validators = {
     return sanitized.endsWith(controlDigits[number % 23]);
   },
   'he-IL': (str) => {
-    const DNI = /^\d+$/;
+    const DNI = /^\d{9}$/;
 
     // sanitize user input
     const sanitized = str.trim();
@@ -43,10 +43,6 @@ const validators = {
 
     const id = sanitized;
 
-    if (id.length !== 9 || isNaN(id)) {
-      // Make sure ID is formatted properly
-      return false;
-    }
     let sum = 0,
       incNum;
     for (let i = 0; i < id.length; i++) {

validator.js

@@ -1137,7 +1137,7 @@ var validators = {
     return sanitized.endsWith(controlDigits[number % 23]);
   },
   'he-IL': function heIL(str) {
-    var DNI = /^\d+$/; // sanitize user input
+    var DNI = /^\d{9}$/; // sanitize user input
 
     var sanitized = str.trim(); // validate the data structure
 
@@ -1146,12 +1146,6 @@ var validators = {
     }
 
     var id = sanitized;
-
-    if (id.length !== 9 || isNaN(id)) {
-      // Make sure ID is formatted properly
-      return false;
-    }
-
     var sum = 0,
         incNum;