Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the Bahrain locale (ar-BH) +973 #1003

Closed
wants to merge 2 commits into from
Closed

Added the Bahrain locale (ar-BH) +973 #1003

wants to merge 2 commits into from

Conversation

heiba
Copy link
Contributor

@heiba heiba commented Mar 13, 2019

No description provided.

@heiba
Copy link
Contributor Author

heiba commented Mar 17, 2019

@chriso Any chance you can have a quick look at that please ? Unable to work in Bahrain mate.

@heiba
Copy link
Contributor Author

heiba commented Apr 2, 2019

@chriso Any chance you can have a quick look at that please ? Unable to work in Bahrain mate.

@profnandaa
Copy link
Member

@heiba -- sorry I'm getting to this late, but going to review your PR right away.

profnandaa
profnandaa requested changes Apr 10, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I see some strange deletetions in your diff, please fix that.
  2. Add tests
  3. Update the README

and we should be good to go. Thanks for the PR! 👍

validator.js
@@ -40,191 +40,6 @@ function _typeof(obj) {
return _typeof(obj);
}

function _toArray(arr) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 330ad51. Not sure why they're on master.

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Apr 10, 2019
@profnandaa
Copy link
Member

@heiba -- any chance you can clean up this PR so that we can have your work in this week?

@heiba
Copy link
Contributor Author

heiba commented Jul 2, 2019 via email

@profnandaa
Copy link
Member

profnandaa commented Jul 2, 2019 via email

@heiba
Copy link
Contributor Author

heiba commented Jul 2, 2019 •
edited
Loading

Hello, I have created a new pull request 1056 . I will close this pull request as it is now a duplicate.

@heiba heiba closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriso chriso chriso left review comments

@profnandaa profnandaa profnandaa requested changes

Assignees
No one assigned
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heiba @profnandaa @chriso