Add support for Armenia phone #1216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1215
Resolves the above-mentioned issue but with a different kind of regex (not the one stated in the issue). That regex was very general. To know more about the format of Armenia phone, view this link.
The format is +374 or 0 followed by 10 plus 6 more digits OR +374 followed by any digit starts with 2 - 9 plus 7 more digits. It can start with +374 or 0. Hence, the regex is
/^(\+?374|0)(10\d{6}$|[2-9]\d{7}$)/