Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nl_NL mobile phone to be correct (including test && src/lib && lib ) #1311

Merged
merged 5 commits into from
May 29, 2020
Merged

Conversation

eriklumbela
Copy link
Contributor

Dutch Mobile phone validator was incorrect, fixed && extended it

6 is not optional: 
  correct: 0612345678, incorrect: 012345678
  - change: '6?' to '6{1}'

countryCode ('+31'), may also contain '00' instead of '+'
  correct, either: '+31612345678' || '0031612345678'
  - change: '(\+)' to '(\+|00)'

when specifying country code it's optional to provide '0' between braces before 6 (eg: '+31(0)6...')
  correct, either: '+31(0)612345678' || +31612345678
- change: ^(((\+|00)?31\(0\))|((\+|00)?31)|0)6{1}\d{8}$
same as previous commit
@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label May 26, 2020
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@profnandaa profnandaa merged commit 1e4011a into validatorjs:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants