Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

China mobile phone number segment supplement #1642

Merged
merged 2 commits into from
Apr 17, 2021
Merged

China mobile phone number segment supplement #1642

merged 2 commits into from
Apr 17, 2021

Conversation

Akira0705
Copy link
Contributor

China mobile phone number segment supplement

Checklist

  • PR contains only changes related; no stray files, etc.
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1642 (dc84b85) into master (63b6162) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1642   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1843      1843           
=========================================
  Hits          1843      1843
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6162...dc84b85. Read the comment docs.

fedeci
fedeci approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Reference: wikipedia

tux-tn
tux-tn approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thank you for your PR and welcome !

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Apr 16, 2021
profnandaa
profnandaa approved these changes Apr 17, 2021
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib and welcome to the project! 🎉

@profnandaa profnandaa merged commit 9ee1b6b into validatorjs:master Apr 17, 2021
@profnandaa profnandaa mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezkemboi ezkemboi ezkemboi approved these changes

@fedeci fedeci fedeci approved these changes

@tux-tn tux-tn tux-tn approved these changes

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Akira0705 @profnandaa @tux-tn @fedeci @ezkemboi