Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isMobilePhone) - Update Hungarian mobile number validation #1826

Merged
merged 3 commits into from
Oct 30, 2021
Merged

fix(isMobilePhone) - Update Hungarian mobile number validation #1826

merged 3 commits into from
Oct 30, 2021

Conversation

danielTiringer
Copy link
Contributor

@danielTiringer danielTiringer commented Oct 24, 2021

The Hungarian mobile number check was missing:

  • the internal-use country code (06)
  • some "recently" added area codes (31 and 50)
  • tests

Relates to #1761
The accuracy can be verified for example via wikipedia

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #1826 (8f3a3cc) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1826   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...8f3a3cc. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you for your PR @danielTiringer 🎉

@tux-tn tux-tn added hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Oct 27, 2021
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa merged commit ba4106f into validatorjs:master Oct 30, 2021
@danielTiringer danielTiringer deleted the 1761-update-hungarian-mobile-number-validation branch October 30, 2021 09:11
theteladras pushed a commit to theteladras/validator.js that referenced this pull request Oct 30, 2021
* Add internal country code option

* Add new area code options

* Add tests to hu mobile number validation
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
* Add internal country code option

* Add new area code options

* Add tests to hu mobile number validation
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
* Add internal country code option

* Add new area code options

* Add tests to hu mobile number validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants