-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(isFQDN): allow_numeric_tld option didn't work #1939
Merged
rubiin
merged 1 commit into
validatorjs:master
from
BigOsvaap:fix-isFQDN-allow_numeric_tld-option
Jul 17, 2022
Merged
fix(isFQDN): allow_numeric_tld option didn't work #1939
rubiin
merged 1 commit into
validatorjs:master
from
BigOsvaap:fix-isFQDN-allow_numeric_tld-option
Jul 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1939 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2085 2085
Branches 472 472
=========================================
Hits 2085 2085
Continue to review full report at Codecov.
|
rubiin
approved these changes
Jul 17, 2022
This was referenced Jun 3, 2024
This was referenced Jun 14, 2024
This was referenced Jun 18, 2024
This was referenced Jun 28, 2024
This was referenced Jul 10, 2024
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the mentioned on this comment #1923 (comment)
the option allow_numeric_tld didn't work as supposed to do, this PR tries to fix that.
Checklist