Fix isMobilePhone regex to allow for ###-###-#### format #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Do you mind rebasing to resolve conflicts, and then adding a test case? |
|
Is this format only for US numbers? Could it be, for a more generalized case, we just sanitize the phone number string by stripping out the const _sanitizePhoneNumber = (number) => number.split('').filter(c => c !== '-').join(''); |
|
Update, just seen @chriso comment here - #826 (comment), I think using |
# Conflicts: # lib/isMobilePhone.js # src/lib/isMobilePhone.js # validator.js # validator.min.js
* 'master' of https://github.com/chriso/validator.js: Additional stuff for validatorjs#858 Fixed semicolon issue Fixed stuff using eslint Created includes function for array to cater older browsers Update the changelog and bundle Iraq locale added 10.4.0 Update the changelog and min version Squased commits, made changes to isIpRange to avoid array destructuring. Update the changelog chore: add tests and update readme Squashing the many disparit commits into a single commit. Bump Update the changelog and min version 10.3.0 Support German numbers without a separator after country code Code updated with test cases Adde Kuwait Number Regex for Mobile Number Validation Accepting array of locales for mobile phone validation # Conflicts: # validator.min.js
tytoons
changed the title
tytoons
changed the title
|
Bubbling this up - #838 (comment) |
|
I think the proposed regex could be even more comprehensive for US numbers. For instance,m the proposed solution does not validate +1(234)3243234, which is a valid US number. I added a new PR with a different regex and more test cases. #872 |
|
Fixed by #872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #826